Include environment when resolving plugin task #1727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adam-fowler it was being set when creating the plugin task: https://github.com/swiftlang/vscode-swift/blob/main/src/tasks/SwiftPluginTaskProvider.ts#L149 but not when resolveTask was called if it was in your tasks.json. Even if not in your tasks.json, there are cases where resolveTask may still get called |
award999
force-pushed
the
resolve-plugin-env
branch
from
77a4dd0 to
49684c5
Compare
matthewbastien
approved these changes
Jul 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide environment variables when
resolveTaskis called on aswift-plugintype task.Issue: #1725
Tasks
Documentation has been updated